[PATCH] D129977: [LoongArch] Support load/store of dso_local PIC global values

Ray Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 17 23:06:27 PDT 2022


wangleiat added a comment.

In D129977#3658733 <https://reviews.llvm.org/D129977#3658733>, @MaskRay wrote:

> In D129977#3658602 <https://reviews.llvm.org/D129977#3658602>, @wangleiat wrote:
>
>> Thanks!
>>
>>> load-store.ll has UB due to out-of-bounds load/store. Fix the UB in the variable
>>> test and add an array test. Note: PIC array index is currently wrong.
>>
>> Spelling mistakes? Is NONPIC?
>
> I pick NOPIC because `-fno-pic` is usually used to refer the position-dependent codegen. NOPIC should be fine.

Sorry, my mistake(Comments without context).

I mean, in  `Summary`, the description of this sentence:

  Note: PIC array index is currently wrong.

Should be replaced by:

  Note: NOPIC array index is currently wrong.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129977/new/

https://reviews.llvm.org/D129977



More information about the llvm-commits mailing list