[PATCH] D129977: [LoongArch] Support load/store of dso_local PIC global values

Ray Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 17 19:23:04 PDT 2022


wangleiat added a comment.

Thanks!

> load-store.ll has UB due to out-of-bounds load/store. Fix the UB in the variable
> test and add an array test. Note: PIC array index is currently wrong.

Spelling mistakes? Is NONPIC?

The wrong array index is due to constant folding with `GlobalAddress` when `isDSOLocal()`.
The interface function of the common layer is `TargetLowering::isOffsetFoldingLegal`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129977/new/

https://reviews.llvm.org/D129977



More information about the llvm-commits mailing list