[PATCH] D129938: [lld-macho] Add support for -alias

[Jez Ng via Phabricator via llvm-commits]

int3 accepted this revision.
int3 added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: lld/MachO/Driver.cpp:1566
 
+    for (auto pair : config->aliasedSymbols) {
+      if (auto *sym = symtab->find(std::get<0>(pair))) {
----------------
int3 wrote:
> `const auto &`
I think you did the next two lines but forgot this one?


================
Comment at: lld/test/MachO/aliases.s:16
+# BAR: [[#%x,FOO_ADDR:]] T _bar
+# BAR: [[#FOO_ADDR]] t _foo
+
----------------
nit: would be nice to align the 2nd column


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129938/new/

https://reviews.llvm.org/D129938