[PATCH] D129324: [llvm] add compression AlgorithmName (s) to the zlib and zstd namespaces

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 17 16:15:06 PDT 2022


dblaikie added a comment.

In D129324#3658393 <https://reviews.llvm.org/D129324#3658393>, @ckissane wrote:

> @dblaikie Yes, the end goal is to make it configurable and eventually refactor to make a shared "compression class" interface where we have zlib and zstd implementations.
> However, this patch is only pointed at adding an implementation of code to call zstd in the first place. Also @MaskRay has an draft patch that demonstrates how this current setup could still be used in a runtime way.
> Note to make that intention clear we have dropped the usage of namespace aliases at the request of @phosek and others.
> Edit:
> TLDR:
> a refactor of compression to use a class interface system is out of scope IMO for this patch

Cool, thanks for the context!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129324/new/

https://reviews.llvm.org/D129324



More information about the llvm-commits mailing list