[PATCH] D129802: [DRAFT] Implementing new atomic orderings in LLVM and generate barriers for legacy __sync builtins. Support corresponding memory model in outline atomics as well.

[Alex Bradbury via Phabricator via llvm-commits]

asb added a comment.

In D129802#3653544 <https://reviews.llvm.org/D129802#3653544>, @efriedma wrote:

> If we do decide we need to do something here, I'd prefer to model this using explicit fences in the IR, as opposed to a new atomic ordering.  Adding extra atomic orderings just makes everything harder to reason about.

+1. I think the bar for adding new memory orderings should be incredibly high. Memory models are complicated enough without introducing esoteric orderings that aren't clearly specified.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129802/new/

https://reviews.llvm.org/D129802