[PATCH] D129756: [IndVars] Directly use unsigned integer induction for FPToUI/FPToSI of float induction

Sat Jul 16 19:55:24 PDT 2022

Allen marked 2 inline comments as done.
Allen added inline comments.

================
Comment at: llvm/test/Transforms/IndVarSimplify/floating-point-small-iv.ll:184
+; https://godbolt.org/z/51MrqYjEf
+define void @uitofp_fptoui_range () {
+; CHECK-LABEL: @uitofp_fptoui_range(
----------------
nikic wrote:
> Allen wrote:
> > nikic wrote:
> > > We should be testing negative ranges as well -- in this case, they would actually be not legal.
> > for unsigned type induction, negative ranges  will be determined true at very early pass, so we don't need check it ?
> >  https://godbolt.org/z/rerdG58cj
> Passes need to be correct in isolation, so I think it is important to still test that case here, even if it gets transformed earlier in the full pipeline.
Done, thanks

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129756/new/

https://reviews.llvm.org/D129756