[PATCH] D129936: [JITLink][COFF][x86_64] Reimplement ADDR32NB/REL32.

Sunho Kim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 16 13:50:52 PDT 2022


sunho added a comment.

@tschuett It's checked in this patch using isInt<32> and also checked another time in x86_64.h when generic relocation edge is used. I also prefer to enum class but all existing code has been using enum. I also don't see an easy way to "extend" enum class. Is there a clever way? (for more context, if we were to swtich to enum class, we must have a way to extend enum as x86_64 edge kind was extended from generic jitlink edge kind in the first place)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129936/new/

https://reviews.llvm.org/D129936



More information about the llvm-commits mailing list