[PATCH] D128582: Move SeparateConstOffsetFromGEPPass() before LSR() and enable EnableGEPOpt by default.

Sat Jul 16 04:00:33 PDT 2022

dmgreen added a comment.

Thanks - Please reread this and see what "with full context" means: https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface. The patch should be created with -U9999999.

I was thinking of the original longer test from the issue, but it is a bit long. This one might be OK too.

================
Comment at: llvm/test/CodeGen/AArch64/cond-br-tuning.ll:33
   %c = add nsw i32 %a, %b
   %d = icmp ne i32 %c, 0
----------------
Change the store here to store 10 not 0. That should keep this testing what it did previously.

================
Comment at: llvm/test/Transforms/SeparateConstOffsetFromGEP/split-gep.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -O3 -mtriple=aarch64-linux-gnu -aarch64-enable-gep-opt | FileCheck %s
+
----------------
Remove -aarch64-enable-gep-opt - it is on by default now.

================
Comment at: llvm/test/Transforms/SeparateConstOffsetFromGEP/split-gep.ll:30
+ ret i32 %res
+
+
----------------
Remove extra line.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128582/new/

https://reviews.llvm.org/D128582