[PATCH] D129518: [BOLT] Add function layout class
Maksim Panchenko via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 15 17:34:31 PDT 2022
maksfb accepted this revision.
maksfb added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: bolt/include/bolt/Core/BinaryFunction.h:2332
static NodeRef getEntryNode(bolt::BinaryFunction *F) {
- return *F->layout_begin();
+ return F->getLayout().front().front();
}
----------------
Same as `block_front()` (same for the next three occurrences)?
================
Comment at: bolt/include/bolt/Core/FunctionLayout.h:81
+/// Interally, the function layout stores blocks across fragments contiguously.
+/// This is neccessary to retain compatilibity with existing code and tests that
+/// iterate over all blocks of the layout and depend on that order. When
----------------
================
Comment at: bolt/include/bolt/Core/FunctionLayout.h:148
+
+ /// Adds BB to the end of the last fragment.
+ void addBasicBlock(BinaryBasicBlock *BB);
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129518/new/
https://reviews.llvm.org/D129518
More information about the llvm-commits
mailing list