[PATCH] D129385: [lsan][Darwin] Scan libdispatch heap

Fri Jul 15 14:50:11 PDT 2022

yln added a comment.

In D129385#3639640 <https://reviews.llvm.org/D129385#3639640>, @lgrey wrote:

> I'm working on enabling LSAN for Mac Chromium

Very cool and good to know! :)

> Are there any public builders running these suites on 13? My 13 machine doesn't have a dev environment so I'd be curious to see if there's anything happening beyond what I'm seeing on 11/12.

Apple doesn't support LSan because we ship the `leaks` tool in our toolchain already that serves this purpose.  I don't think we are running `check-lsan` anywhere.
However, I think that this mostly worked on macOS until recently (before macOS 13?) so I initially thought that your are fixing that problem.

> Instead of suppressing, WDYT about just ignoring the relevant regions? Details on why this happens here: https://docs.google.com/document/d/11h3N06tN-_n7nbwVK8qTRnWz3paICI_HlrVM8BvmZ9s

Yes, I think that sounds like a better approach.

Now, that I better understand what this revision is trying to do my general feedback would be: if we fix a false positive, it would be nice to have a test for it!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129385/new/

https://reviews.llvm.org/D129385