[llvm] 041bb94 - Revert "[lit][unit] makes sure to print stderr when no test failures are found"

[Yuanfang Chen via llvm-commits]

Author: Yuanfang Chen
Date: 2022-07-15T13:26:30-07:00
New Revision: 041bb94b9ce92a0133fe5e241336f8d3ff65048e

URL: https://github.com/llvm/llvm-project/commit/041bb94b9ce92a0133fe5e241336f8d3ff65048e
DIFF: https://github.com/llvm/llvm-project/commit/041bb94b9ce92a0133fe5e241336f8d3ff65048e.diff

LOG: Revert "[lit][unit] makes sure to print stderr when no test failures are found"

This reverts commit 65769429c0644c81d271e9d971f5b64191503f6e.

This patch is incomplete.

Added: 
    

Modified: 
    llvm/utils/lit/lit/formats/googletest.py

Removed: 
    


################################################################################
diff  --git a/llvm/utils/lit/lit/formats/googletest.py b/llvm/utils/lit/lit/formats/googletest.py
index 6878ebcb5456a..5feefaa84f12e 100644
--- a/llvm/utils/lit/lit/formats/googletest.py
+++ b/llvm/utils/lit/lit/formats/googletest.py
@@ -163,8 +163,6 @@ def get_test_stdout(test_name):
                     res.append(l)
             assert False, f'gtest did not report the result for ' + test_name
 
-        found_failed_test = False
-
         with open(test.gtest_json_file, encoding='utf-8') as f:
             jf = json.load(f)
 
@@ -181,7 +179,6 @@ def get_test_stdout(test_name):
                     header = f"Script:\n--\n%s --gtest_filter=%s\n--\n" % (
                         ' '.join(cmd), testname)
                     if 'failures' in testinfo:
-                        found_failed_test = True
                         output += header
                         test_out = get_test_stdout(testname)
                         if test_out:
@@ -192,12 +189,6 @@ def get_test_stdout(test_name):
                     elif result != 'COMPLETED':
                         output += header
                         output += 'unresolved test result\n'
-
-        # In some situations, like running tests with sanitizers, all test passes but
-        # the shard could still fail due to memory issues.
-        if not found_failed_test:
-            output += f"\n{out}\n--\nexit: {exitCode}\n--\n"
-
         return lit.Test.FAIL, output
 
     def prepareCmd(self, cmd):