[PATCH] D129894: [lld-macho][nfc] Add more tests + comments around ICF + unwind info interaction

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 15 12:26:27 PDT 2022


int3 created this revision.
int3 added a reviewer: lld-macho.
Herald added projects: lld-macho, All.
int3 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

While working on D129830: [lld-macho] Support folding of functions with identical LSDAs <https://reviews.llvm.org/D129830>, I realized that our handling of ICF +
eh_frame combined was untested. Additionally I realized that the comment
explaining why we were safely slicing away the functionAddress reloc
from our compact unwind entries was... insufficient and slightly
misleading. I've tried to clarify it.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D129894

Files:
  lld/MachO/InputFiles.cpp
  lld/test/MachO/icf.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129894.445099.patch
Type: text/x-patch
Size: 5400 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220715/5e6ae060/attachment.bin>


More information about the llvm-commits mailing list