[PATCH] D129559: Windows packaging script. Include lld-link, llvm-lib and llvm-windres from stage0

[Hans Wennborg via Phabricator via llvm-commits]

hans added inline comments.


================
Comment at: llvm/utils/release/build_llvm_release.bat:72
+if exist %build_dir% (
+  REM Exit if the build directory already exists.
+  echo Build directory already exists: %build_dir%
----------------
nit: I'd drop the comment here, the code is clear enough.


================
Comment at: llvm/utils/release/build_llvm_release.bat:147
+  -DPython3_ROOT_DIR=%PYTHONHOME% ^
+  -DPYTHON_EXECUTABLE=%PYTHONHOME%\python.exe ^
+  -DLIBXML2_INCLUDE_DIRS=%libxmldir%/include/libxml2 ^
----------------
I don't think we were setting PYTHON_EXECUTABLE before?


================
Comment at: llvm/utils/release/build_llvm_release.bat:171
+cmake -GNinja %cmake_flags% ..\llvm-project\llvm || exit /b
 ninja || ninja || ninja || exit /b
 REM ninja check-llvm || ninja check-llvm || ninja check-llvm || exit /b
----------------
If this or some other build step fails, we would previously exit the script. Now I think we will just exit this "sub routine". Is that what we want?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129559/new/

https://reviews.llvm.org/D129559