[PATCH] D129786: [llvm] add zstd to `llvm::compression` namespace

Cole Kissane via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 15 11:18:48 PDT 2022


ckissane added a comment.

In D129786#3654396 <https://reviews.llvm.org/D129786#3654396>, @sebastian-ne wrote:

> It seems like FindZSTD.cmake went missing in the Diff 3 revision of this patch?

yes because facebook is surprisingly good at "modern cmake" practices with shipping libzstd and so ```find_dependency(zstd)``` is enough to have the lib ```zstd::libzstd_shared``` get defined!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129786/new/

https://reviews.llvm.org/D129786



More information about the llvm-commits mailing list