[PATCH] D129759: [AMDGPU] Set amdgpu-memory-bound if a basic block has dense global memory access

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

In D129759#3655803 <https://reviews.llvm.org/D129759#3655803>, @abinavpp wrote:

> In D129759#3652782 <https://reviews.llvm.org/D129759#3652782>, @rampitec wrote:
>
>> Is the actual block you are considering in the regressed app inside a loop? Is that a "small single bb loop", i.e. when the bb branches right to itself? This is more likely to be a "dense memory access code" (and you will not need LoopInfo).
>
> Yes, the block is in a loop in the regressed kernel, but unfortunately it
> doesn't branch to itself. So I guess we need LoopInfo. Unfortunately, I don't
> think there's any way to get the LoopInfo analysis from a CallGraphSCCPass in
> the legacy pass manager. I think we could use the
> FunctionAnalysisManagerCGSCCProxy in the new pass manager
> (https://llvm.org/docs/NewPassManager.html#using-analyses). Do you see any
> problem in adding the new pass manager here? Or did I miss any other way to do
> this in the legacy pass manager for now?

No, I do not like to bring a new analysis here and a new PM either. Maybe we should try this as is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129759/new/

https://reviews.llvm.org/D129759