[PATCH] D129866: [llvm-size] Fix hang on invalid short commandline option

[Owen Reynolds via Phabricator via llvm-commits]

gbreynoo created this revision.
gbreynoo added reviewers: MaskRay, jhenderson, kazu, Higuoxing.
Herald added subscribers: StephenFan, rupprecht.
Herald added a project: All.
gbreynoo requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

When an invalid shot command line option was used (e.g. -v) llvm-size would hang. This change fixes this issue by bringing llvm-size in line with other llvm tools and exiting early when this error is output.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D129866

Files:
  llvm/tools/llvm-size/llvm-size.cpp


Index: llvm/tools/llvm-size/llvm-size.cpp
===================================================================
--- llvm/tools/llvm-size/llvm-size.cpp
+++ llvm/tools/llvm-size/llvm-size.cpp
@@ -868,8 +868,11 @@
   StringSaver Saver(A);
   SizeOptTable Tbl;
   ToolName = argv[0];
-  opt::InputArgList Args = Tbl.parseArgs(argc, argv, OPT_UNKNOWN, Saver,
-                                         [&](StringRef Msg) { error(Msg); });
+  opt::InputArgList Args =
+      Tbl.parseArgs(argc, argv, OPT_UNKNOWN, Saver, [&](StringRef Msg) {
+        error(Msg);
+        exit(1);
+      });
   if (Args.hasArg(OPT_help)) {
     Tbl.printHelp(
         outs(),


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129866.444995.patch
Type: text/x-patch
Size: 652 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220715/ccaec0fb/attachment.bin>