[PATCH] D125784: [llvm-dva] 09 - CodeView Reader

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso added inline comments.


================
Comment at: llvm/lib/DebugInfo/CodeView/TypeRecordHelpers.cpp:54
+
+uint64_t llvm::codeview::getSize(TypeIndex TI) {
+  if (!TI.isSimple())
----------------
CarlosAlbertoEnciso wrote:
> djtodoro wrote:
> > CarlosAlbertoEnciso wrote:
> > > djtodoro wrote:
> > > > I guess this should be a standalone patch.
> > > > 
> > > > What about `getSizeInBytes()` instead?
> > > That is a very good point.
> > > Would you prefer all the changes to `TypeRecordHelpers.cpp[h]` be moved in a standalone patch?
> > > `getSizeInBytes()` sounds good.
> > > Would you prefer all the changes to TypeRecordHelpers.cpp[h] be moved in a standalone patch?
> > I vote for that.
> I will prepare a standalone patch to include the changes to `TypeRecordHelpers.cpp[h]`.
Created https://reviews.llvm.org/D129846


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125784/new/

https://reviews.llvm.org/D125784