[PATCH] D129825: Fix assertion in SmallDenseMap constructor with reserve from non-power-of-2 buckets count
Andrew Trick via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 14 21:21:26 PDT 2022
atrick accepted this revision.
atrick added a comment.
This revision is now accepted and ready to land.
LGTM. I don't understand how no one has hit the assert. Or maybe they have and just changed their code to workaround it.
It's a little strange that the power-of-2 fix isn't handled directly in SmallDenseMap::init.
Someone might think it's strange that the initial size heuristic does not match DenseMap--but I don't think that matters here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129825/new/
https://reviews.llvm.org/D129825
More information about the llvm-commits
mailing list