[PATCH] D128544: [Orc][JITLink] Add a shared memory based implementation of MemoryMapper

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 14 17:03:39 PDT 2022


lhames added a comment.

LGTM otherwise -- thanks for chasing up the fix @argentite.



================
Comment at: llvm/lib/ExecutionEngine/Orc/CMakeLists.txt:2
+if( CMAKE_HOST_UNIX AND HAVE_LIBRT )
+  set(rt_lib rt)
+endif()
----------------
As @thakis suggested I think this should be `LLVM_RT_LIB` (for consistency with `LLVM_PTHREAD_LIB`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128544/new/

https://reviews.llvm.org/D128544



More information about the llvm-commits mailing list