[PATCH] D129813: [AMDGPU] Add IPO pass to infer pointer argument address spaces. WIP.

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/InferArgumentAddressSpaces.cpp:139
+                      << "' to address space " << I.second << '\n');
+
+    PointerType *PT = dyn_cast<PointerType>(Arg->getType());
----------------
arsenm wrote:
> It would be better to replace the actual argument list with the new type too, and update all the users
This would be a lot of code, at least copy most of the stuff from InferAddressSpaces itself, cloning function, updating calls, updating SCC...

Is it worth it? I.e. what do your think it would make better?

In any way, if needed it is better to go in a separate change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129813/new/

https://reviews.llvm.org/D129813