[PATCH] D129728: [llvm-dwp] Add SHF_COMPRESSED support and remove .zdebug support

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/lib/DWP/DWP.cpp:282-285
+  bool IsLE = isa<object::ELF32LEObjectFile>(Obj) ||
+              isa<object::ELF64LEObjectFile>(Obj);
+  bool Is64 = isa<object::ELF64LEObjectFile>(Obj) ||
+              isa<object::ELF64BEObjectFile>(Obj);
----------------
MaskRay wrote:
> dblaikie wrote:
> > This should probably be in a separate patch with test coverage (though generally I don't think adding functionality/doing work on llvm-dwp is really worth it - it probably needs to be thrown out & start again to make it sufficiently efficient in terms of memory usage, etc - though with the WebAssembly (so the costly abstractions are now load-bearing to support WebAssembly) support added & lld's non-generality (so doesn't have sufficient abstractions to make it trivial to implement over different formats), it's not clear what the foundation of such a new implementation would be, whether the generality can be maintained while achieving the desired performance, etc).
> > 
> > A FIXME could document what's entailed in adding the endian/size functionality here.
> Will add a TODO that this is untested (some binary utilities use TODO to indicate no test coverage as well).
> 
> Thanks for the insight that llvm-dwp probably should be re-implemented. I haven't followed the development...
> 
> (@ckissane)
I'd prefer it not be checked in untested. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129728/new/

https://reviews.llvm.org/D129728