[PATCH] D129677: Disable machine function splitting for functions with inline asm br

Thu Jul 14 14:23:18 PDT 2022

adriantong1024 added a comment.

In D129677#3653221 <https://reviews.llvm.org/D129677#3653221>, @nickdesaulniers wrote:

> In D129677#3653097 <https://reviews.llvm.org/D129677#3653097>, @adriantong1024 wrote:
>
>> The problem this patch is trying to fix is discovered on AArch64 where the conditional branch b.ge is too short after MFS places hot and cold blocks apart.
>
> Isn't it straightforward to change b.ge to b.lt to the other branch destination, then b (no condition) to the label?

We can do this. I am slightly worried about performance as this is in a performance critical part of the code.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129677/new/

https://reviews.llvm.org/D129677