[PATCH] D129585: [BOLT] Replace uses of layout with basic block list

[Maksim Panchenko via Phabricator via llvm-commits]

maksfb accepted this revision.
maksfb added a comment.
This revision is now accepted and ready to land.

LGTM. Please address a couple if nits before commit.



================
Comment at: bolt/lib/Core/BinaryFunction.cpp:3514
+  SmallVector<BinaryBasicBlock *> EntryPoints;
+  copy_if(BasicBlocks, std::back_inserter(EntryPoints),
+          [&](const BinaryBasicBlock *const BB) { return isEntryPoint(*BB); });
----------------
nit:


================
Comment at: bolt/lib/Core/BinaryFunction.cpp:3518
+  // order.
+  stable_sort(EntryPoints, [](const BinaryBasicBlock *const A,
+                              const BinaryBasicBlock *const B) {
----------------
nit:


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129585/new/

https://reviews.llvm.org/D129585