[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

> https://github.com/llvm/llvm-project/issues/56514
>
> Fixes #56514

Just use `Fixes https://github.com/llvm/llvm-project/issues/56514` or `Fixes #56514`. GitHub can close the issue automatically.



================
Comment at: clang/test/CodeGen/attr-function-return.c:9
 // RUN:  --check-prefixes=CHECK,CHECK-EXTERN
+// RUN: %clang_cc1 -std=gnu2x -triple x86_64-linux-gnu %s -emit-llvm -o - \
+// RUN:  -mfunction-return=thunk-extern -fprofile-arcs \
----------------
I feel that having 3 RUN lines is excessive. Since we already have a test that asan/tsan/gcov respect getModuleFlag, it is not necessary for a new one to duplicate all the combinations.


================
Comment at: llvm/docs/LangRef.rst:7370
   a synthesized function will get the ``uwtable(async)`` function attribute.
+- "fn_return_thunk_extern": The synthesized function will get the
+  ``fn_return_thunk_extern`` function attribute.
----------------
keep the list sorted


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129709/new/

https://reviews.llvm.org/D129709