[PATCH] D128014: [AMDGPU] Improve assembler + disassembler handling of kernel descriptors

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.h:100
   mutable bool HasLiteral;
+  mutable Optional<bool> EnableWavefrontSize32;
 
----------------
Can this be a plain `bool`?


================
Comment at: llvm/test/tools/llvm-objdump/ELF/AMDGPU/kd-zeroed-gfx10.s:4
 ; RUN: llvm-mc %s --triple=amdgcn-amd-amdhsa -mcpu=gfx1010 -mattr=-xnack -filetype=obj -o %t
-; RUN: llvm-objdump -s -j .text %t | FileCheck --check-prefix=OBJDUMP %s
+; RUN: llvm-objdump -d -s -j .text %t | FileCheck --check-prefix=OBJDUMP %s
 
----------------
I'd prefer -s before -d because in the llvm-objdump output, the `-s` part precedes the `-d` part.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128014/new/

https://reviews.llvm.org/D128014