[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:1222
+  // printing multiple diagnostic location and diag opts.
+  EmitResourceUsageRemark("KernelName", "Kernel Name",
+                          MF.getFunction().getName());
----------------
vangthao wrote:
> arsenm wrote:
> > Why is this kernel name? Do we not emit these for other functions?
> We do emit these for other functions. Would this be better off as "Function Name" instead of kernel?
Yes


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123878/new/

https://reviews.llvm.org/D123878