[PATCH] D128014: [AMDGPU] Improve assembler + disassembler handling of kernel descriptors
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 14 10:20:14 PDT 2022
MaskRay added inline comments.
================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1414
+ outs() << Ctx.getAsmInfo()->getCommentString()
+ << " Error in decoding " << SymbolName
<< " : Decoding failed region as bytes.\n";
----------------
diagnostics are recommended not to be capitalized. llvm-objdump sticks with this convention quite well: https://llvm.org/docs/CodingStandards.html#error-and-warning-messages
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128014/new/
https://reviews.llvm.org/D128014
More information about the llvm-commits
mailing list