[PATCH] D129478: [IR] Remove support for float binop constant expressions

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

@jgorbe Thanks for the report! To start with, I landed a change to make this report an error instead of crash: https://github.com/llvm/llvm-project/commit/159feac1c0a26dccc6dd8726bd71d073cda5faea

I'm a bit unsure how to handle the metadata situation further. Actually expanding the constant expression sounds like quite the PITA because metadata is read before the function, so we wouldn't know where to insert the instructions at that point. As debuginfo auto-upgrade is not supported (the "upgrade" action for debuginfo is to strip it completely), I'm inclined to simply replace the metadata with an undef or poison value (which llvm.debug.value handles fine).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129478/new/

https://reviews.llvm.org/D129478