[PATCH] D129612: [Reassociate] Cleanup minor missed optimizations

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 14 07:38:49 PDT 2022


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

In D129612#3650193 <https://reviews.llvm.org/D129612#3650193>, @wristow wrote:

> Addressed review comments from @spatel , except for adding an integer test.

...

> the change does clean the results up //somewhat//, but not as completely as the floating-point version.  Specifically, //without// the change, the above test is reassociated to:

I'd prefer to have that test, so we have coverage for the integer path added with this patch. It's still an improvement even if it's not as big as the FP side.
Other than that, LGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129612/new/

https://reviews.llvm.org/D129612



More information about the llvm-commits mailing list