[PATCH] D129571: Build Windows releases with libxml enabled, to unbreak llvm-mt

[Hans Wennborg via Phabricator via llvm-commits]

hans added a comment.

In D129571#3645827 <https://reviews.llvm.org/D129571#3645827>, @penzn wrote:

> This change LGTM, can we also add some description of this process to developer docs? Anyone who would building LLVM on Windows is going to be hit by `llvm-mt` errors in current Visual Studio versions.

Sent https://reviews.llvm.org/D129770 for the docs update.

In D129571#3651781 <https://reviews.llvm.org/D129571#3651781>, @CarlosAlbertoEnciso wrote:

> @hans Looking at your changes as part of https://reviews.llvm.org/D129559, the stage1 configuration fails with the error:
>
>   -- Looking for xmlReadMemory
>   -- Looking for xmlReadMemory - not found
>   CMake Error at cmake/config-ix.cmake:156 (message):
>     Failed to configure libxml2
>
> I think the issue is with the `-DLIBXML2_INCLUDE_DIR`. Looking at the CMake documentation:
>
> `LIBXML2_INCLUDE_DIR`   the directory containing LibXml2 headers
> `LIBXML2_INCLUDE_DIRS` list of the include directories needed to use LibXml2
>
>   list(APPEND CMAKE_REQUIRED_INCLUDES ${LIBXML2_INCLUDE_DIRS})
>   list(APPEND CMAKE_REQUIRED_LIBRARIES ${LIBXML2_LIBRARIES})
>   ...
>   check_symbol_exists(xmlReadMemory libxml/xmlreader.h HAVE_LIBXML2)
>   ...
>   if(LLVM_ENABLE_LIBXML2 STREQUAL FORCE_ON AND NOT HAVE_LIBXML2)
>     message(FATAL_ERROR "Failed to configure libxml2")
>   endif()
>
> The CMake script is looking in `${LIBXML2_INCLUDE_DIRS}`
> Changing from `-DLIBXML2_INCLUDE_DIR=....` to `-DLIBXML2_INCLUDE_DIRS=...` solved the issue and managed to build both 32/64 binaries.

It worked on my machine :-/ I suppose CMake may have changed (I used 3.20). Let me check if changing to LIBXML2_INCLUDE_DIRS works for me also...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129571/new/

https://reviews.llvm.org/D129571