[PATCH] D128177: [DebugInfo][InstrRef][NFC] Represent DbgValues with multiple ops in LDV

Stephen Tozer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 14 06:28:24 PDT 2022


StephenTozer updated this revision to Diff 444630.
StephenTozer added a comment.

Update unit tests. The changes are all trivial; the changes were performed primarily by regex substitution, and simply update DbgValue constructors in the tests to use a DbgOpID instead of a ValueIDNum, creating the former in most cases with a test function `addValueDbgOp` that creates an ID for a Value in the standard way. For the `vlocJoin` tests, there was no need to create the underlying value, as `vlocJoin` does not actually need to view it - it only checks equality and const-ness, which can be done entirely from the ID.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128177/new/

https://reviews.llvm.org/D128177

Files:
  llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp
  llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h
  llvm/unittests/CodeGen/InstrRefLDVTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D128177.444630.patch
Type: text/x-patch
Size: 78806 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220714/95ab0c84/attachment-0001.bin>


More information about the llvm-commits mailing list