[PATCH] D129756: [IndVars] Directly use unsigned integer induction for FPToUI/FPToSI of float induction

Allen zhong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 14 06:00:17 PDT 2022


Allen added a comment.

In D129756#3651567 <https://reviews.llvm.org/D129756#3651567>, @nikic wrote:

> I think this is correct as written, but also confusing. It would make more sense to me if for fptoui we used getUnsignedRange() and getActiveBits() and for fptosi used getSignedRange() and getMinSignedBits().

Done, thanks very much for your careful and patient guidance.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129756/new/

https://reviews.llvm.org/D129756



More information about the llvm-commits mailing list