[PATCH] D127383: Don't treat readnone call in presplit coroutine as not access memory

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 14 05:33:14 PDT 2022


nhaehnle added a comment.

In D127383#3650988 <https://reviews.llvm.org/D127383#3650988>, @nikic wrote:

> Do we also need to upgrade argmemonly to inaccessibleorargmemonly? Assuming that the thread ID counts as inaccessible memory.

Nit: I wouldn't say thread ID counts as inaccessible memory, rather it's something that is apart entirely (given the change for `readnone`).

I think it would be consistent to say that an `argmemonly` function is allowed to read the thread ID. That does suggest that analogous changes for `onlyAccessesArgMemory` are needed, but I haven't thought about it very carefully.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127383/new/

https://reviews.llvm.org/D127383



More information about the llvm-commits mailing list