[PATCH] D129764: [ORC][COFF] Properly set weak flag to COMDAT symbols.

[Sunho Kim via Phabricator via llvm-commits]

sunho created this revision.
Herald added a subscriber: hiraditya.
Herald added a project: All.
sunho requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Properly set weak flag to COMDAT symbols so that no duplicate definition error will be generated. There is an inaccuracy in setting plain weak for largest selection type, which will be dealt with soon when largest type is properly implemented.


https://reviews.llvm.org/D129764

Files:
  llvm/lib/ExecutionEngine/Orc/ObjectFileInterface.cpp
  llvm/test/ExecutionEngine/JITLink/X86/COFF_comdat_weak_duplicate.s
  llvm/test/ExecutionEngine/JITLink/X86/COFF_comdat_weak_plus_strong.s
  llvm/test/ExecutionEngine/JITLink/X86/COFF_strong_duplicate.s
  llvm/test/ExecutionEngine/JITLink/X86/Inputs/COFF_comdat_weak_def.yaml
  llvm/test/ExecutionEngine/JITLink/X86/Inputs/COFF_strong_def.yaml

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129764.444614.patch
Type: text/x-patch
Size: 8214 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220714/ea5870ed/attachment.bin>