[PATCH] D129713: [obj2yaml] Add -o to specify output filename

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 14 00:25:04 PDT 2022


MaskRay added inline comments.


================
Comment at: llvm/tools/obj2yaml/obj2yaml.cpp:64
   case file_magic::offload_binary:
-    return offload2yaml(outs(), MemBuf);
+    return offload2yaml(OS, MemBuf);
   default:
----------------
jhenderson wrote:
> I guess there isn't an appropriate offloading test case you could update like you have with the others?
Found a suitable test: updated `llvm/test/ObjectYAML/Offload/default.yaml`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129713/new/

https://reviews.llvm.org/D129713



More information about the llvm-commits mailing list