[PATCH] D128907: [Clang] Disable noundef attribute for languages which allow uninitialized function arguments

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 13 22:07:46 PDT 2022


jdoerfert requested changes to this revision.
jdoerfert added a comment.
This revision now requires changes to proceed.

Wasn't there a discussion about this before, or some other patch? If so, could we please link such things (e.g., in the commit message) so people don't have to remember and find the links themselves.

FWIW, I don't think this is the right approach. For one, assuming we want such a logic, I would expect the default of the flag to change and not some hidden stuff that makes the still exposed flag meaningless.
That said, I doubt this is even what we want. Throwing away the benefits of the noundef for one special case. IIRC, I mentioned alternatives in the other discussion already,... not that I have a link handy.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128907/new/

https://reviews.llvm.org/D128907



More information about the llvm-commits mailing list