[PATCH] D129630: [SCEVExpander] Make CanonicalMode handing in isSafeToExpand() more robust (PR50506)

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM to this patch as is.  I agree with @fhahn's comments, but those are reasonable follow ups and don't need to be done in this patch.  This is already is a significant improvement.

As a follow up thought, have you considered whether the member function variant of isSafeToExpand could be implemented in terms of isSafeToExpandAt with the internal insertion point?  Not sure if that's a good idea or not...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129630/new/

https://reviews.llvm.org/D129630