[PATCH] D129519: [Symbolizer] Implement contextual symbolizer markup elements.

[Daniel Thornburgh via Phabricator via llvm-commits]

mysterymath updated this revision to Diff 444465.
mysterymath added a comment.

Fixed use after free with MarginNodes. MarginNodes ended up being unnecessary,
since when a new module line is opened, the next thing to print will
necessarily be that module line. That means the next things to be output will
be the margin nodes, and these can be summarily printed.

This is also true for the prefix of the module info line, but the code seems a
bit cleaner if the info handling is centralized in flushModuleInfo().


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129519/new/

https://reviews.llvm.org/D129519

Files:
  llvm/docs/CommandGuide/llvm-symbolizer.rst
  llvm/docs/SymbolizerMarkupFormat.rst
  llvm/include/llvm/DebugInfo/Symbolize/Markup.h
  llvm/include/llvm/DebugInfo/Symbolize/MarkupFilter.h
  llvm/lib/DebugInfo/Symbolize/Markup.cpp
  llvm/lib/DebugInfo/Symbolize/MarkupFilter.cpp
  llvm/test/DebugInfo/symbolize-filter-markup-context-line-elision.test
  llvm/test/DebugInfo/symbolize-filter-markup-mmap.test
  llvm/test/DebugInfo/symbolize-filter-markup-module.test
  llvm/test/DebugInfo/symbolize-filter-markup-parse-fields.test
  llvm/test/DebugInfo/symbolize-filter-markup-reset.test
  llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129519.444465.patch
Type: text/x-patch
Size: 28905 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220714/70136feb/attachment.bin>