[PATCH] D129540: [lld-macho] Enable EH frame parsing / pruning

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

Here are repro files. Sorry it took a bit.

Chromium Framework for intel: https://drive.google.com/file/d/10uskfM01xf86XW3Qk8_eJDoQO9h5831W/view?usp=sharing

Same, but with -femit-dwarf-unwind=no-compact-unwind in cflags (but not in asmflags – from what I understand, the flag has no effect for asm files): https://drive.google.com/file/d/1GG1xAGhvIC3vrofJpskxuYSTfQz2w--N/view?usp=sharing

(at chromium rev 3dac9776078c561f24f,
use_goma = true
is_debug = false
symbol_level = 0

followed steps in https://bugs.llvm.org/show_bug.cgi?id=48657#c0

my local diff for adding the flag:

  diff --git a/build/config/mac/BUILD.gn b/build/config/mac/BUILD.gn
  index fa114a572138c..db0eedf7de21e 100644
  --- a/build/config/mac/BUILD.gn
  +++ b/build/config/mac/BUILD.gn
  @@ -55,6 +55,9 @@ config("compiler") {
     if (export_libcxxabi_from_executables) {
       ldflags += [ "-Wl,-undefined,dynamic_lookup" ]
     }
  +  cflags += [ "-femit-dwarf-unwind=no-compact-unwind" ]
   }

)

The flag shouldn't be needed on iOS since that's arm64…oh I guess maybe for iOS simulator it's needed too, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129540/new/

https://reviews.llvm.org/D129540