[PATCH] D129677: Disable machine function splitting for functions with inline asm br

[James Y Knight via Phabricator via llvm-commits]

jyknight added a comment.

I don't think we should make this change.

> Should it not be the compiler's job not to break valid inline assembly user put into their code?

I would argue that in this case, the asm is not "valid" -- it makes an unwarranted assumption as to the compiler's output. Unless there is a way to specify with an inline-asm constraint that the target address must be nearby, the assembly code cannot in general make such an assumption.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129677/new/

https://reviews.llvm.org/D129677