[PATCH] D129698: [llvm] fix zlib buffer truncate edge cases and fix nits in tests

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 13 15:00:56 PDT 2022


phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/unittests/Support/CompressionTest.cpp:26
 #if LLVM_ENABLE_ZLIB
-
-void TestZlibCompression(StringRef Input, int Level) {
+static void testZlibCompression(StringRef Input, int Level) {
   SmallString<32> Compressed;
----------------
I'd probably omit changes to this file since they're not really necessary (and not even described in your commit message).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129698/new/

https://reviews.llvm.org/D129698



More information about the llvm-commits mailing list