[PATCH] D129695: [ARM] Fix Thumb2 compare being emitted ExpandCMP_SWAP

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 13 14:35:29 PDT 2022


efriedma added a comment.

Is there some rule that ensures TempReg is a low register?  I guess the register allocator for thumbv8m.baseline currently doesn't choose high registers, but that's sort of fragile.  I'd prefer to make the pseudo-instruction explicitly constrain the register class if that's necessary.



================
Comment at: llvm/lib/Target/ARM/ARMExpandPseudoInsts.cpp:1853
   bool IsThumb = STI->isThumb();
+  bool IsThumb1Only = STI->isThumb1Only();
   MachineInstr &MI = *MBBI;
----------------
strexd doesn't exist in thumbv8m.baseline?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129695/new/

https://reviews.llvm.org/D129695



More information about the llvm-commits mailing list