[PATCH] D129693: [ARM] Don't emit Arm speculation hardening thunks under Thumb and vice-versa

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 13 13:56:40 PDT 2022


dmgreen created this revision.
dmgreen added reviewers: kristof.beyls, ostannard.
Herald added subscribers: jsji, pengfei, hiraditya.
Herald added a project: All.
dmgreen requested review of this revision.
Herald added a project: LLVM.

Given a patch like D129506 <https://reviews.llvm.org/D129506>, using instructions not valid for the current target feature set becomes an error. This means that emitting Arm instructions in a Thumb target (or vice versa) becomes an error. As far as I can tell when running in Thumb mode only thumb thunks will be needed though, and in Arm mode only arm thunks are needed. This patch limits the emitted thunks to just the ones valid for the current architecture.


https://reviews.llvm.org/D129693

Files:
  llvm/include/llvm/CodeGen/IndirectThunks.h
  llvm/lib/Target/AArch64/AArch64SLSHardening.cpp
  llvm/lib/Target/ARM/ARMSLSHardening.cpp
  llvm/lib/Target/X86/X86IndirectThunks.cpp
  llvm/test/CodeGen/ARM/speculation-hardening-sls.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129693.444414.patch
Type: text/x-patch
Size: 4201 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220713/6260828d/attachment-0001.bin>


More information about the llvm-commits mailing list