[PATCH] D128302: [AArch64][CostModel] Detects that ExtractElement at index is not free in AArch64 when result is used as integer.

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.h:176
 
+  using BaseT::getVectorInstrCost;
   InstructionCost getVectorInstrCost(unsigned Opcode, Type *Val,
----------------
mingmingl wrote:
> davidxl wrote:
> > what is the purpose of the using statement here?
> Oh good catch. This is a mistake. 'using statement' is not needed for AArch64 since there is an override for new interface.
Is it needed for other targets? The new method is a public method in BasicTTIImplBase, which is inherited and visible in the derived class.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128302/new/

https://reviews.llvm.org/D128302