[PATCH] D129525: [GlobalOpt] Drop SRA split limit for struct types.

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

@fhahn I think your last update is missing the code changes :)

I assume that you don't actually care about SRA as such, but rather about some follow-on transforms it enables. I've been thinking that we might want to make GlobalOpt in general work on the SRAd representation internally, which might remove the need to actually materialize it in some cases. So if some parts of the global are never written, it will certainly always be profitable to replace them with (part of) the initializer, regardless of how many parts there are. The limit is only relevant for cases where we actually do leave behind the globals. Do you know which optimization in particular is important for your workload?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129525/new/

https://reviews.llvm.org/D129525