[PATCH] D128958: Add assembler plumbing for sanitize_memtag

Wed Jul 13 11:56:50 PDT 2022

enh added a comment.

In D128958#3648965 <https://reviews.llvm.org/D128958#3648965>, @MaskRay wrote:

> The implementation looks good to me. I assume that you have authority to define a value in `SHT_ANDROID_*`.

i own Android's elf.h and dynamic linker [citations needed: https://cs.android.com/android/platform/superproject/+/master:bionic/libc/include/elf.h and https://cs.android.com/android/platform/superproject/+/master:bionic/OWNERS], and this lgtm :-)

> My only concern is whether regular AArch64 may need something similar in the future, then whether the section name `.memtag.globals` and the directive name `.memtag` may cause a recognition conflict.
> Technically the assembler may decode the environment from the target triple (`aarch64-linux-android31`) and do different things on Android and on non-Android, but I personally favor different section names/directives
> which can help Android migrate to the standard.
>
> @Wilco1 @peter.smith

yeah, ideally we'll be able to get everyone in sync in the end, even if we have to ship first (like with the compressed relocations stuff).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128958/new/

https://reviews.llvm.org/D128958