[PATCH] D128560: An upcoming patch to LLDB will require the ability to decode base64. This patch adds support for decoding base64 and adds tests.

Greg Clayton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 13 11:55:30 PDT 2022


clayborg updated this revision to Diff 444371.
clayborg added a comment.

Don't expose the invalid byte definition since this is in a header file. decodeBase64Byte() now makes its own "Inv" version so it can be used to initialize a large array and the name needs to be short, and the decodeBase64() function makes its own version named Base64InvalidByte for readability. No one outside of this header file needs to access this variable so we shouldn't expose it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128560/new/

https://reviews.llvm.org/D128560

Files:
  llvm/include/llvm/Support/Base64.h
  llvm/unittests/Support/Base64Test.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D128560.444371.patch
Type: text/x-patch
Size: 8048 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220713/49551000/attachment.bin>


More information about the llvm-commits mailing list