[PATCH] D129653: isInductionPHI - Add some safety checks

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added inline comments.


================
Comment at: llvm/lib/Analysis/IVDescriptors.cpp:1509
+
+  if (!Phi)
+    return false;
----------------
fhahn wrote:
> This should never be called with `Phi` being null.
Sounds like a good case for Phi being a `&` (and additional `const`) rather than a non-const ptr.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129653/new/

https://reviews.llvm.org/D129653