[PATCH] D126827: [llvm-profgen] Fix a loading address bug for pseudo probe profile

Wed Jul 13 11:33:03 PDT 2022

hoy added inline comments.

================
Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:745
+        if (UseLoadableSegmentAsBase) {
+          Start -= Binary->getFirstLoadableAddress();
+          End -= Binary->getFirstLoadableAddress();
----------------
wlei wrote:
> hoy wrote:
> > I'm a bit confused here. What is the semantics of using both offset and LoadableSegmentAsBase?
> I think this is to be compatible to our internal old tool where some services use offset and the FirstLoadableAddress as the output of unsymbolized profile.
> 
> The original patch is https://reviews.llvm.org/D113727.
Do we still need this now? The offset here is computed by subtracting the runtime base address from preferred-based virtual address. This seems different from what previous computed, ie., subtracting the runtime base address from runtime virtual address.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126827/new/

https://reviews.llvm.org/D126827