[PATCH] D129337: [llvm-objcopy][ELF] Add --set-section-type

[Fangrui Song via Phabricator via llvm-commits]

MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: llvm/docs/CommandGuide/llvm-objcopy.rst:130
 
  Set the alignment of section ``<section>`` to `<align>``. Can be specified
  multiple times to update multiple sections.
----------------
jhenderson wrote:
> Unrelated, but if you get a moment whilst updating this doc, would you mean fixing the typo with the uneven ` characters around "<align>", please?
Thanks for spotting this! Fixed separately in ccfc54028860a71780361128f861444825a24a05


================
Comment at: llvm/docs/CommandGuide/llvm-objcopy.rst:174
+
+ For ELF objects, set the type for a given section to the integer <type>.
+
----------------
jhenderson wrote:
> I suggest adopting the wording that --set-section-alignment uses. Something like this would be good:
> 
> ```
> Set the type of section ``<section>`` to the integer ``<type>``. Can be specified multiple times to update multiple sections.
> ```
> 
> As this option is ELF-only, it should be put under the "ELF-SPECIFIC OPTIONS" section of the doc.
Thanks for the suggestion. Moved and updated the wording.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129337/new/

https://reviews.llvm.org/D129337